TryBugHunt
cppOff-by-oneHard

Six-digit amounts start with a comma

BugFind the bug and fix the code

What it should do

withCommas(amount) formats a positive whole number with a comma between each group of three digits. Example: withCommas(1234567) → "1,234,567"

What happens instead

withCommas(123456) returns ",123,456" and withCommas(999) returns ",999".

#include <string>

std::string withCommas(long amount) {
    std::string s = std::to_string(amount);
    for (int i = (int)s.size() - 3; i >= 0; i -= 3) {
        s.insert(i, ",");
    }
    return s;
}

Test a custom input to verify an edge case (e.g. empty lists, negative numbers, duplicates).

⏱️0:00
Hints
🏆 0 hints = Flawless Solve
Think & Test Cooldown
2:00 remaining

Take a moment to read the bug symptom and trace the code with Run & Check before unlocking Hint 1.

Hint 2
Unlocks after Hint 1
Hint 3
Unlocks after Hint 2

This bug belongs to the off-by-one errors pattern

The loop that runs one time too many, the slice that drops the last item, the index that starts in the wrong place.

What you'll practise

A hard C++ debugging exercise about off-by-one errors: the loop that runs one time too many, the slice that drops the last item, the index that starts in the wrong place.

The checks your fix must pass

Signs of this kind of bug

Spoiler: why this bug happens(try it first; the hints get warmer one at a time)

What went wrong: The loop inserts a comma at every position that is a multiple of three from the right, including position 0. When the digit count is a multiple of three, position 0 is reached and a comma is put in front of the first digit. 1234567 looks fine because its loop jumps from 1 to -2 and skips 0.

The fix: A separator only belongs between digits, so stop at i > 0.

Remember: When you insert separators, the very start and end are never valid places. Test lengths that are exact multiples of the group size.

The pattern behind it: off-by-one errors.

More off-by-one errors to practise

Embed this challenge on your site

Paste this into any web page or blog post. Visitors fix the bug right there, in their browser.

<iframe src="https://trybughunt.com/embed/489345b5-1dd7-40cf-9e4e-2c421f3dd783" title="Debugging challenge: Six-digit amounts start with a comma" width="100%" height="580" loading="lazy" style="border:1px solid #d4d4d8;border-radius:12px;max-width:760px"></iframe>
<p style="font-size:14px">Debugging challenge from <a href="https://trybughunt.com/challenges/489345b5-1dd7-40cf-9e4e-2c421f3dd783">TryBugHunt</a></p>