TryBugHunt
cppOff-by-oneMedium

AI Attempt: Binary search misses the largest value

🤖 AI Code ReviewSpot the flaw in the AI assistant's solution

An AI assistant wrote this implementation with complete confidence. It passes standard inputs, but fails on a subtle edge case — the exact skill tested in modern AI-assisted interview rounds. Audit the logic, isolate what the model missed, and make it production-ready.

What it should do

An AI assistant wrote this binary search. findIndex(sorted, target) returns the index of target in a sorted vector, or -1 if it is not there. Example: findIndex({1, 3, 5, 7, 9}, 9) → 4

What happens instead

findIndex({1, 3, 5, 7, 9}, 9) returns -1 although 9 is at index 4.

#include <vector>

int findIndex(std::vector<int> sorted, int target) {
    int lo = 0, hi = (int)sorted.size() - 1;
    while (lo < hi) {
        int mid = (lo + hi) / 2;
        if (sorted[mid] == target) return mid;
        if (sorted[mid] < target) lo = mid + 1;
        else hi = mid - 1;
    }
    return -1;
}

Test a custom input to verify an edge case (e.g. empty lists, negative numbers, duplicates).

⏱️0:00
Hints
🏆 0 hints = Flawless Solve
Think & Test Cooldown
2:00 remaining

Take a moment to read the bug symptom and trace the code with Run & Check before unlocking Hint 1.

Hint 2
Unlocks after Hint 1
Hint 3
Unlocks after Hint 2

This bug belongs to the off-by-one errors pattern

The loop that runs one time too many, the slice that drops the last item, the index that starts in the wrong place.

What you'll practise

A medium C++ debugging exercise about off-by-one errors: the loop that runs one time too many, the slice that drops the last item, the index that starts in the wrong place.

The checks your fix must pass

Signs of this kind of bug

Spoiler: why this bug happens(try it first; the hints get warmer one at a time)

What went wrong: lo and hi are both inclusive bounds, so when lo == hi there is still one value left to check. while (lo < hi) stops right then, so a target that ends up as the last candidate is never compared.

The fix: Keep looping while lo <= hi.

Remember: Pick one convention and stick to it. With hi = size - 1 (inclusive) the loop is lo <= hi and you move hi = mid - 1. With hi = size (exclusive) it is lo < hi and hi = mid.

The pattern behind it: off-by-one errors.

More off-by-one errors to practise

Embed this challenge on your site

Paste this into any web page or blog post. Visitors fix the bug right there, in their browser.

<iframe src="https://trybughunt.com/embed/648dad0d-7900-4c43-8eff-5fe5343c9495" title="Debugging challenge: AI Attempt: Binary search misses the largest value" width="100%" height="580" loading="lazy" style="border:1px solid #d4d4d8;border-radius:12px;max-width:760px"></iframe>
<p style="font-size:14px">Debugging challenge from <a href="https://trybughunt.com/challenges/648dad0d-7900-4c43-8eff-5fe5343c9495">TryBugHunt</a></p>