TryBugHunt
cppLogic errorHard

Shallow copy of pointer member in custom class

BugFind the bug and fix the code

What it should do

Clone ValueHolder and update clone value without mutating original. Example: cloneValueHolder(10, 20) -> [10, 20]

What happens instead

Mutating clone also mutates original due to default memberwise copy

#include <iostream>
#include <vector>

class ValueHolder {
public:
    int* val;
    ValueHolder(int v) : val(new int(v)) {}
    ~ValueHolder() { delete val; }
    // Missing custom copy constructor; default copy copies raw pointer address
};

std::vector<int> cloneValueHolder(int origVal, int newVal) {
    ValueHolder v1(origVal);
    ValueHolder v2 = v1; // Shallow copy: both share same int* val
    *v2.val = newVal;
    return {*v1.val, *v2.val};
}

int main() {
    std::vector<int> res = cloneValueHolder(10, 20);
    return 0;
}

Test a custom input to verify an edge case (e.g. empty lists, negative numbers, duplicates).

⏱️0:00
Hints
🏆 0 hints = Flawless Solve
Think & Test Cooldown
2:00 remaining

Take a moment to read the bug symptom and trace the code with Run & Check before unlocking Hint 1.

Hint 2
Unlocks after Hint 1
Hint 3
Unlocks after Hint 2

This bug belongs to the logic errors pattern

The wrong operator, an inverted condition, a formula the right way round but backwards.

What you'll practise

A hard C++ debugging exercise about logic errors: the wrong operator, an inverted condition, a formula the right way round but backwards.

The checks your fix must pass

Signs of this kind of bug

Spoiler: why this bug happens(try it first; the hints get warmer one at a time)

What went wrong: The compiler-generated default copy constructor performs a shallow memberwise copy of pointers. v1.val and v2.val point to the same memory address, mutating both and causing double-free on destruction.

The fix: Implement a custom copy constructor that allocates a new int and copies the dereferenced value: ValueHolder(const ValueHolder& other) : val(new int(*other.val)) {}.

Remember: Follow the Rule of Three/Five: if a class manages a raw resource with a custom destructor, define custom copy and move operations.

The pattern behind it: logic errors.

More logic errors to practise

Embed this challenge on your site

Paste this into any web page or blog post. Visitors fix the bug right there, in their browser.

<iframe src="https://trybughunt.com/embed/b8817706-07a4-444e-b1e3-bd235648f549" title="Debugging challenge: Shallow copy of pointer member in custom class" width="100%" height="580" loading="lazy" style="border:1px solid #d4d4d8;border-radius:12px;max-width:760px"></iframe>
<p style="font-size:14px">Debugging challenge from <a href="https://trybughunt.com/challenges/b8817706-07a4-444e-b1e3-bd235648f549">TryBugHunt</a></p>