TryBugHunt
cppLogic errorMedium

Set iteration fails unexpectedly after element modification

BugFind the bug and fix the code

What it should do

Modify each element in the set by adding 1 and print the set. Example: f({1, 2, 3}) -> {2, 3, 4}

What happens instead

Runtime error: set iterator not incrementable

#include <iostream>
#include <set>

void modifyAndPrintSet(std::set<int>& s) {
  for (auto it = s.begin(); it!= s.end(); ++it) {
    *it += 1;  // Incorrect modification
  }
  for (const auto& elem : s) {
    std::cout << elem << " ";
  }
}

int main() {
  std::set<int> s = {1, 2, 3};
  modifyAndPrintSet(s);
  return 0;
}

Test a custom input to verify an edge case (e.g. empty lists, negative numbers, duplicates).

⏱️0:00
Hints
🏆 0 hints = Flawless Solve
Think & Test Cooldown
2:00 remaining

Take a moment to read the bug symptom and trace the code with Run & Check before unlocking Hint 1.

Hint 2
Unlocks after Hint 1
Hint 3
Unlocks after Hint 2

This bug belongs to the logic errors pattern

The wrong operator, an inverted condition, a formula the right way round but backwards.

What you'll practise

A medium C++ debugging exercise about logic errors: the wrong operator, an inverted condition, a formula the right way round but backwards.

The checks your fix must pass

Signs of this kind of bug

Spoiler: why this bug happens(try it first; the hints get warmer one at a time)

What went wrong: Directly modifying elements inside a std::set while iterating corrupts the BST ordering, leading to undefined behavior.

The fix: Create a new set for modified elements to preserve the original set's integrity.

Remember: Never modify elements of a std::set while iterating over it; use a separate container for modifications.

The pattern behind it: logic errors.

More logic errors to practise

Embed this challenge on your site

Paste this into any web page or blog post. Visitors fix the bug right there, in their browser.

<iframe src="https://trybughunt.com/embed/2ef3da45-9f69-4a8c-8094-5eafa777a95d" title="Debugging challenge: Set iteration fails unexpectedly after element modification" width="100%" height="580" loading="lazy" style="border:1px solid #d4d4d8;border-radius:12px;max-width:760px"></iframe>
<p style="font-size:14px">Debugging challenge from <a href="https://trybughunt.com/challenges/2ef3da45-9f69-4a8c-8094-5eafa777a95d">TryBugHunt</a></p>