TryBugHunt
cppOtherMedium

Two negatives in a row: only one gets removed

BugFind the bug and fix the code

What it should do

removeNegatives(nums) removes every negative number and keeps the rest in order. Example: removeNegatives({1, -2, -3, 4}) → {1, 4}

What happens instead

removeNegatives({1, -2, -3, 4}) returns [1, -3, 4].

#include <vector>

std::vector<int> removeNegatives(std::vector<int> nums) {
    for (size_t i = 0; i < nums.size(); i++) {
        if (nums[i] < 0) nums.erase(nums.begin() + i);
    }
    return nums;
}

Test a custom input to verify an edge case (e.g. empty lists, negative numbers, duplicates).

⏱️0:00
Hints
🏆 0 hints = Flawless Solve
Think & Test Cooldown
2:00 remaining

Take a moment to read the bug symptom and trace the code with Run & Check before unlocking Hint 1.

Hint 2
Unlocks after Hint 1
Hint 3
Unlocks after Hint 2

This bug belongs to the mutation and copying bugs pattern

Copies where you meant references, references where you meant copies, and shallow copies of pointers.

What you'll practise

A medium C++ debugging exercise about mutation and copying bugs: copies where you meant references, references where you meant copies, and shallow copies of pointers.

The checks your fix must pass

Signs of this kind of bug

Spoiler: why this bug happens(try it first; the hints get warmer one at a time)

What went wrong: erase shifts every later element one place to the left. After -2 at index 1 is erased, -3 moves into index 1, but the loop then does i++ and checks index 2. -3 is skipped.

The fix: Only move to the next index when nothing was erased: put i++ in an else branch. The erase-remove idiom with std::remove_if is another good fix.

Remember: When you erase while looping by index, the next element slides into the current spot. Do not advance the index after an erase.

The pattern behind it: mutation and copying bugs.

More mutation and copying bugs to practise

Embed this challenge on your site

Paste this into any web page or blog post. Visitors fix the bug right there, in their browser.

<iframe src="https://trybughunt.com/embed/569112e3-3327-473f-ab1e-4d434da41e52" title="Debugging challenge: Two negatives in a row: only one gets removed" width="100%" height="580" loading="lazy" style="border:1px solid #d4d4d8;border-radius:12px;max-width:760px"></iframe>
<p style="font-size:14px">Debugging challenge from <a href="https://trybughunt.com/challenges/569112e3-3327-473f-ab1e-4d434da41e52">TryBugHunt</a></p>