TryBugHunt
cppLogic errorHard

Password with a digit in the middle rejected as weak

BugFind the bug and fix the code

What it should do

strongPassword(pw) is true when the password has at least 8 characters, at least one digit and at least one capital letter. Example: strongPassword("S3cretword") → true

What happens instead

strongPassword("S3cretword") returns false, while "Secret123" returns true.

#include <cctype>
#include <string>

bool strongPassword(std::string pw) {
    if (pw.size() < 8) return false;
    bool hasDigit = false, hasUpper = false;
    for (char c : pw) {
        hasDigit = std::isdigit((unsigned char)c);
        if (std::isupper((unsigned char)c)) hasUpper = true;
    }
    return hasDigit && hasUpper;
}

Test a custom input to verify an edge case (e.g. empty lists, negative numbers, duplicates).

⏱️0:00
Hints
🏆 0 hints = Flawless Solve
Think & Test Cooldown
2:00 remaining

Take a moment to read the bug symptom and trace the code with Run & Check before unlocking Hint 1.

Hint 2
Unlocks after Hint 1
Hint 3
Unlocks after Hint 2

This bug belongs to the logic errors pattern

The wrong operator, an inverted condition, a formula the right way round but backwards.

What you'll practise

A hard C++ debugging exercise about logic errors: the wrong operator, an inverted condition, a formula the right way round but backwards.

The checks your fix must pass

Signs of this kind of bug

Spoiler: why this bug happens(try it first; the hints get warmer one at a time)

What went wrong: hasDigit = isdigit(c) overwrites the flag on every character. A digit sets it to true, but the next letter sets it back to false, so only the last character decides. The capital-letter check is written correctly, which is why only digits fail.

The fix: Only ever set the flag to true: if (std::isdigit((unsigned char)c)) hasDigit = true;

Remember: A "found at least one" flag must never be reset inside the loop. If a check only works when the thing is at the end of the input, look for an assignment that runs on every step.

The pattern behind it: logic errors.

More logic errors to practise

Embed this challenge on your site

Paste this into any web page or blog post. Visitors fix the bug right there, in their browser.

<iframe src="https://trybughunt.com/embed/9605a2be-748f-4f09-a8d9-055221885e9d" title="Debugging challenge: Password with a digit in the middle rejected as weak" width="100%" height="580" loading="lazy" style="border:1px solid #d4d4d8;border-radius:12px;max-width:760px"></iframe>
<p style="font-size:14px">Debugging challenge from <a href="https://trybughunt.com/challenges/9605a2be-748f-4f09-a8d9-055221885e9d">TryBugHunt</a></p>